search

iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
964 stars 574 forks source link

Renders transaction summary at the end of the sign command. #5129

Closed patnir closed 2 months ago

patnir commented 2 months ago

Summary

Renders transaction summary at the end of the sign command.

Testing Plan

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes
NullSoldier commented 2 months ago

Irrelevant to this PR But I noticed that transaction details are broken. I sent some iron to myself on testnet and this was the output summary.

==================
Notes sent:
==================

==================
Notes received:
==================

Amount:        $IRON 0.00000001
Memo:          testing
Recipient:     ...
Sender:        ...

------------------

Amount:        $IRON 0.00000003
Memo:
Recipient:     ...
Sender:        ...