iron-fish / node-app

Electron-based Node App
https://ironfish.network/use/node-app
17 stars 8 forks source link

feat(ifl-996): snapshot optional modal #290

Closed jowparks closed 1 year ago

jowparks commented 1 year ago

This PR does a few things:

  1. Allows user to decline snapshot, this was an easier change because of how integrated the snapshot system is into the user flow (instead of making the snapshot an optional flow).
  2. On decline, starts the node/peer network and begins syncing
  3. Modal opens immediately after snapshot manifest is retrieved, rather than chain being initialized
  4. Snapshot modal is not dismissible

Cancel download/Sync flow:

https://github.com/iron-fish/node-app/assets/26990067/8857bcd1-a69a-4c01-b117-742ffcd58814

Download complete flow:

https://github.com/iron-fish/node-app/assets/26990067/59462bd2-4750-4b11-bd83-eae0c5e9aa59

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wallet-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 5:18pm
skylarrichard123 commented 1 year ago

@jowparks 3 things:

• could we add 16px spacing between the two buttons • Copy change - I feel like this isn't explaining the choices for all types of users. I think it might be worth fleshing this out to something like,

"Choose how to sync your app with the blockchain:

Download Snapshot: Fast and centralized. Get a complete copy quickly from a central source. This method ensures efficiency and consistent data.

Sync from Peers: Slower but decentralized. Retrieve the blockchain from other users, contributing to network decentralization. While it may take longer, it strengthens the network's resilience."

• Make the buttons copy sentence case like with the option titles. In particular, :"Sync from peers" as button copy is inconsistent with "Download Snapshot". Make it "Sync From Peers".

jowparks commented 1 year ago

After PR comments:

Screenshot 2023-05-26 at 9 11 46 AM