iron-fish / node-app

Electron-based Node App
https://ironfish.network/use/node-app
17 stars 8 forks source link

Fix migration ID and name loading in webpack #328

Closed dguenther closed 1 year ago

dguenther commented 1 year ago

The migrations load their ID and name dynamically using __fileName. This doesn't work when the files are bundled together using webpack, and it's not easy to separate webpack from electron-forge, so for now we can overwrite __filename in the migration files with the original filename.

We should probably consider fixing this in the SDK to embed the name and ID directly in the migrations rather than loading them dynamically, but this will work for now without an SDK deployment.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wallet-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 7:50pm
jowparks commented 1 year ago

Hacking skillz, good stop gap until we can fix migrations file.