iron-io / dockers

Uber tiny Docker images for all the things.
http://www.iron.io
MIT License
1.59k stars 139 forks source link

Creating separate Dockerfiles for the JRE and JDK #5

Closed arschles closed 9 years ago

arschles commented 9 years ago

the java-1.x images are just the JRE, we should use them for production. the java-dev-1.x ones have the JDK so used for local development, debugging, etc…

cc/ @treeder this addresses a TODO that you had in java/java-1.7/README.md

the new iron/java-dev images are already up on dockerhub and updated readme is in https://github.com/iron-io/dockerworker/pull/20, but the iron/java images haven't changed. will do so when ready to merge.

treeder commented 9 years ago

Should always have a latest tag on Docker HUB too with most recent version.

treeder commented 9 years ago

Also, you may have pushed the wrong images to Docker hub for the dev images. They are the same size and appear to be using the full jdk: https://imagelayers.io/?images=iron%2Fphp:latest,iron%2Fphp-composer:latest,iron%2Fpython3:latest,iron%2Fpython:latest,iron%2Fjava:1.7.0,iron%2Fjava:1.8,iron%2Fruby:latest,iron%2Fjava-dev:1.8,iron%2Fjava-dev:1.7

arschles commented 9 years ago

@treeder don't think I understand your question?

I didn't push new images for iron/java yet because they were already there, will do so after merge. also the java-dev ones are supposed to have the full jdk.

treeder commented 9 years ago

Oh right, the iron/java ones have to change, got it.

arschles commented 9 years ago

@treeder is this all good? would like to push iron/java to dockerhub before merging https://github.com/iron-io/dockerworker/pull/20 (still have some changes in progress there anyway)