search

iron-io / dockerworker

The new IronWorker workflow examples. Test locally, then upload and start queuing jobs!
http://www.iron.io
232 stars 47 forks source link

payload / params magic gone #1

Closed rdallman closed 8 years ago

rdallman commented 9 years ago

I think this was a design goal and think it's fine, but now tasks can't simply access the payload from, e.g. @payload like they were able to before -- this requires some changes to the current user code and we should make a note of it to warn them ahead of time (or consider superior alternatives).

treeder commented 9 years ago

Ya, I think we'll want to create new libs or add to existing libs a couple of helper functions. But these libs would be tiny, like this helper for Ruby: https://github.com/iron-io/dockerworker/blob/master/iron_worker.rb

Thoughts?

rdallman commented 9 years ago

yea, I think that's great.

treeder commented 9 years ago

Actually, most of our other libs should work the same way they do now in terms of loading payloads and what not, I think the Ruby one is the only strange one because ng did special magic for Ruby libs.