search

iron-io / dockerworker

The new IronWorker workflow examples. Test locally, then upload and start queuing jobs!
http://www.iron.io
232 stars 47 forks source link

Add config file option to docker run command in node subfolder #32

Closed gchaturvedi closed 8 years ago

treeder commented 8 years ago

@gchaturvedi thanks for the PR, but we're trying to deprecate config files in favor of environment variables: http://www.iron.io/blog/2016/01/custom-docker-images-and-private-docker-repos-and-environment-vars.html

ENV vars with Docker are a lot cleaner/nicer.

gchaturvedi commented 8 years ago

Ah okay, so we should switch over? I can close this PR then.