iron-software / IronSoftware.System.Drawing

An open-source System.Drawing.Common replacement for .NET 5 and above on all platforms. Bringing together System.Drawing, Maui, and ImageSharp's Bitmap, Image, Font, and Shape types via an agnostic free NuGet package.
Other
120 stars 19 forks source link

Using netstandard2.0 and net60 #50

Closed mee-ironsoftware closed 1 year ago

mee-ironsoftware commented 1 year ago

Note: This PR is intended to demonstrate a solution for separating net60 from netstandard2.0 and using different SixLabors.ImageSharp versions, proving that the approach works correctly.

Title

Update IronDrawing to targets netstandard2.0 and net60 with different SixLabors.ImageSharp versions.

Description

This PR updates IronDrawing to target both netstandard2.0 and net60 frameworks. To accommodate these changes, IronDrawing now uses different versions of SixLabors.ImageSharp for each framework: v2.1.3 for netstandard2.0 and v3.0.0 for net60. Some source code adjustments have been made to ensure compatibility with both versions of SixLabors.ImageSharp.

Fixes #SLACK-MESSAGE

Type of change

Please select the relevant option by placing an 'x' inside the brackets, like this: [x].

How Has This Been Tested?

Run through all the Unit tests locally.

Checklist:

Please run through the checklist as much as possible and mark the items completed by placing an 'x' inside the brackets, like this: [x].

Additional Context

This PR prepares IronDrawing for supporting both netstandard2.0 and net60 frameworks and ensures compatibility with the respective SixLabors.ImageSharp versions.

artem-iron commented 1 year ago

Can you use this opportunity to also add netstandard 2.1 target also? This is needed to enable better mobile compatibility.

mee-ironsoftware commented 1 year ago

Can you use this opportunity to also add netstandard 2.1 target also? This is needed to enable better mobile compatibility.

Good idea.