iron / router

Router middleware for the Iron web framework.
165 stars 74 forks source link

fix nightly build #149

Closed miller-time closed 5 years ago

miller-time commented 5 years ago

closes #148

I guess route-recognizer is no longer maintained? My PR: https://github.com/conduit-rust/route-recognizer.rs/pull/25 comment from Alex Crichton: https://github.com/conduit-rust/route-recognizer.rs/pull/26#issuecomment-519534860

miller-time commented 5 years ago

Travis CI got this warning+error, and I ran cargo +nightly build locally and got the same thing:

warning: Patch `route-recognizer v0.1.12 (https://github.com/miller-time/route-recognizer.rs?rev=d7bc06d2dc58a2c59d8f2cfbee2ab23b8188700d#d7bc06d2)` was not used in the crate graph.
Check that the patched package version and available features are compatible
with the dependency requirements. If the patch has a different version from
what is locked in the Cargo.lock file, run `cargo update` to use the new
version. This may also occur with an optional dependency that is not enabled.

 error[E0463]: can't find crate for `recognizer`
 --> src/lib.rs:7:1
  |
7 | extern crate route_recognizer as recognizer;
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate

Looks like this isn't actually an option...

miller-time commented 5 years ago

Well, I read the cargo docs and discovered that I made this change incorrectly. I shouldn't have removed dependencies.route-recognizer when adding patch.crates-io.route-recognizer.

phlmn commented 5 years ago

Thanks for the PR!

I just merged https://github.com/iron/iron/pull/591, the router crate now lives inside workspace in the main repo (https://github.com/iron/iron/tree/master/router). Could you move the PR?

miller-time commented 5 years ago

@phlmn done - https://github.com/iron/iron/pull/614

phlmn commented 5 years ago

Thanks! 🙂

phlmn commented 5 years ago

Moved to https://github.com/iron/iron/pull/614