search

iron / staticfile

Static file-serving middleware for the Iron web framework.
MIT License
63 stars 56 forks source link

Possible fix for HEAD requests #57

Closed gsquire closed 8 years ago

gsquire commented 8 years ago

This is in reference to #54. I am not sure if this is the right place to do so, however.

reem commented 8 years ago

I think the best place for this code would be somewhere both the cache and non-cache paths could call it, see the response created in Cache::response_with_cache.

gsquire commented 8 years ago

@reem I updated the code to use the response_with_cache method. If it looks good, I will squash.

gsquire commented 8 years ago

@reem I can close this PR if it's gone stale. The issue it references is still open.

gsquire commented 8 years ago

Rebased and squashed old commits.

Hoverbear commented 8 years ago

@gsquire Thank you for being persistent with this. I'm going to help you merge this. :)

Please see my comment about .unwrap() and after that I'll make sure we get this merged!

gsquire commented 8 years ago

@Hoverbear Thanks for the comments. I was first learning Rust when I made this PR so that showed :)

I can squash when you give me a thumbs up.

Hoverbear commented 8 years ago

@gsquire LGTM. :) Thanks so much.