iron / staticfile

Static file-serving middleware for the Iron web framework.
MIT License
63 stars 56 forks source link

Support client caching #97

Open kpcyrd opened 7 years ago

kpcyrd commented 7 years ago

I'm trying to serve assets using this crate, but I've noticed the server does not send an Etag. This would cause the client to request the asset every time it's referenced (so, on every page load).

The express framework is sending an etag on static mounts, the client would memorize this and include it in future requests, if the server notices the file hasn't changed, it's sending back an 304.

This is critical for page speed and bandwidth. :)

vmchale commented 7 years ago

If you add

staticfile = {version = "0.4", features=["cache"]}

to your Cargo.toml, it will enable caching.

vmchale commented 7 years ago

Here is an example:

use staticfile::{Static, Cache};
use std::time::Duration;

...

    let one_week = Duration::new(7*24*3600,0);
    let mut css_stat = Static::new(Path::new("static/css"));
    Cache::new(one_week).modify(&mut css_stat);
    router.mount("/css/", css_stat);
Hoverbear commented 7 years ago

Perhaps we should add some documentation of this!