search

iron / staticfile

Static file-serving middleware for the Iron web framework.
MIT License
63 stars 56 forks source link

Add Partial Content Delivery (+tests) #98

Closed agersant closed 3 years ago

agersant commented 7 years ago

This is a follow up to https://github.com/iron/staticfile/pull/95. @Cobrand doesn't seem to be active on Github anymore but his pending PR adding partial content responses is very valuable to me. I added unit tests to his code, please let me know if anything else needs to happen for this to be merged!

Cobrand commented 7 years ago

I am still active on GitHub and I saw your PR on my fork, and I wanted to get to it this week-end but you beat me to it. It's true that lately I haven't as much time as I wished I had, because you know, life'n'stuff.

Anyway I'm grateful that you're taking care of this now, I was starting to feel guilty about not implementing the tests to have this merged.

About the tests themselves, if I were you I would also add some tests for the errors as well. (requesting a byterange were the minimum is higher than the file total, requesting a from -1 in the headers, things like that... but still, great work and thank you again.

agersant commented 7 years ago

I should have been a bit more patient, I know how busy things can get :c

I'll add a few tests for invalid requests, that's a good point.

agersant commented 7 years ago

Any update regarding the possibility/timeline of this being merged?

Emielvanbetsbrugge commented 6 years ago

Hey guys, this works great, we're using this pull request in a video renderer. Should be good to go in. Cheers.

rockwotj commented 5 years ago

Ping!

rockwotj commented 5 years ago

Maybe @untitaker would be willing to review/merge this?

agersant commented 5 years ago

At this point I would recommend migrating to a web framework that is still maintained.

rockwotj commented 5 years ago

Is this not maintained? A deprecation warning would be nice

agersant commented 5 years ago

Yeah, Iron hasn't had a commit in a very long time. I think everyone uses Rocket, Actix-Web or some other frameworks now.