iron431 / irons-spells-n-spellbooks

Other
78 stars 57 forks source link

[Bug] FTB Presents Direwolf 1.20 Generating certain chunks causes server to lag indefinitely #367

Open dylithian opened 5 months ago

dylithian commented 5 months ago

Observed behaviour

Mod version in the pack: irons_spellbooks-1.20.1-2.2.1.jar

Error has also been observed in irons_spellbooks-1.20.1-3.1.1.jar

When certain chunks on the map are generated for the first time, the server stops responding and lags without crashing until the watchdog kills it when the max-tick-time is reached.

The logs don't seem to implicate this mod at all, and I had to discover this by removing mods one-by-one. Removing the mod and returning to the area does not reproduce the issue.

Expected behaviour

Generating chunks should not make the server stop responding. If an error is encountered, an error message should be thrown.

Steps to reproduce

  1. Generate a world with the seed marauders3
  2. Run the command /tp -890 66 165
  3. Move westward (vaguely) and wait for chunks to load
  4. Observe that even in singleplayer, the server stops responding. Saving and quitting to title freezes the game, as the server does not respond to the command to save.

NOTE: This issue happens both in single player and on a dedicated server.

Server Type

Dedicated Server

Crashlog

No response

Iron's Spells N Spellbooks version

irons_spellbooks-1.20.1-2.2.1.jar

Forge version

Neoforge 47.1.84

Other mods

All mods in version 1.12.1 11614 on the FTB Presents Direwolf 1.20 modpack.

Link to the modpack mods list

iron431 commented 5 months ago

do you have a log to provide?

dylithian commented 5 months ago

latest.log debug.log

Shybella commented 4 months ago

Encountering this too

image

Something with iron spells structures? What can be a temporary solution? On Direwolf20 1.20.1

Chunk generation thread locks however main tick thread does not, the picture above points to what's locking the chunk generation thread

Shybella commented 4 months ago

I'm assuming this is caused by the catacombs structure?

iron431 commented 4 months ago

its being caused by the remove water processor. we're looking in to what may be causing this. one known conflict is ferrite core, so if you are using that, disable the threading detector config

Shybella commented 4 months ago

its being caused by the remove water processor. we're looking in to what may be causing this. one known conflict is ferrite core, so if you are using that, disable the threading detector config

Replace objects used to detect multi-threaded access to chunks by a much smaller field. This option is disabled by default due to very rare and very hard-to-reproduce crashes, use at your own risk!

useSmallThreadingDetector = false

This was already set to false.

Shybella commented 4 months ago

This kind of stuff should have been solved months ago,

Direwolf20 saves are getting bricked out the box, I can't believe anyone from the FTB Team couldn't solve this. How is the end user ever going to be able to identify tough problems like this. The modpack teams are not like they use to be, sad days.

Iron431 this isn't caused by you, bugs happen all the time. This issue has plagued DW20 for awhile now and it's the FTB Teams job to resolve it and they failed to properly identify it causing 1000's of people to have this issue and ultimately causing them to start a new save.

I want to thank you iron431 for even responding to me. It's more than I got out of the FTB Team. Good people, thanks buddy.

Shybella commented 1 month ago

Oh wow, ran into this again and found stuff I forgot about