iron431 / irons-spells-n-spellbooks

Other
77 stars 57 forks source link

[Bug] Compatibility issue with Tetra MOD #493

Open nekotya opened 2 months ago

nekotya commented 2 months ago

Observed behaviour

Resource pack with frosted_helve translation didn't work.

Expected behaviour

image After applying the resource pack containing the above, using frosted_helve on the handle was expected to be translated.

Key listed in "/data/tetra/materials/rod/frosted_helve.json" were not translated because they are incompatible with tetra. Although it is written as "key":"frosted_helve", I think it should be written as "key":"irons_spellbooks_frosted_helve". The resource pack does not function properly due to the above

Also, it would be helpful if you could add the following to the Japanese settings.

"tetra.material.irons_spellbooks_frosted_helve": "フロストヘルブ", "tetra.material.irons_spellbooks_frosted_helve.prefix": "凍える",

Steps to reproduce

  1. install tetra & iron_spellbooksfor 1.20.1
  2. apply resource pack that includes: image
  3. Change the tool handle to frosted_helve

Server Type

Single Player

Crashlog

No response

Iron's Spells N Spellbooks version

irons_spellbooks-1.20.1-3.2.0

Forge version

forge-1.20.1-47.3.3

Other mods

No response

meeprdib commented 2 months ago

You also need to provide translations for tetra.variant.basic_hilt/frosted_helve and tetra.variant.basic_handle/frosted_helve.

nekotya commented 2 months ago

Even if I added those two, the translation didn't work.

Also, Frozen Bones etc. was translated without mentioning these two. We have confirmed that the translation is successful after editing the contents of the jar file and adding the following three items.

/data/tetra/materials/rod/frosted_helve.json "key":"frosted_helve"

/asset/irons_spellbooks/lang/ja_jp.jspn "tetra.material.irons_spellbooks_frosted_helve", "tetra.material.irons_spellbooks_frosted_helve.prefix"

meeprdib commented 2 months ago

You can make a PR to fix this