iron431 / irons-spells-n-spellbooks

Other
77 stars 57 forks source link

[Bug] Priest Render Crash in Villages #536

Open Syndrous opened 1 month ago

Syndrous commented 1 month ago

Observed behaviour

The game crashes with the following error when loading a village with a Priest:

The game crashed whilst rendering entity in world Error: java.lang.IllegalStateException: Not building!

Not entirely sure what the cause is, as I cannot get close enough to see the Priests. This is in ATM 10 0.33 and 0.32, I've reported the issue to their team as well.

Expected behaviour

Enter a village with Priest and not crash.

Steps to reproduce

  1. Find a village.
  2. Enter said village.

Server Type

Single Player

Crashlog

https://gist.github.com/Syndrous/03d034aad6f33d1304367812b3de33be

Iron's Spells N Spellbooks version

1.21.1-3.4.4

Forge version

NeoForge: 21.1.8

Other mods

No response

Syndrous commented 1 month ago

Here is my latest.log for this crash.

Xaunther commented 1 month ago

Same thing, in my case the crash happened a few minutes after entering the village and now it crashes inmediately after joining the game. I'll now try to isolate the mod and see if the crash persists

Sloner42 commented 4 weeks ago

I was able to reproduce the same/similar crash reliable in new worlds. And will add my own crash report on this one:

Observed behaviour: Crash observed 2 times. 2nd time was reproduceable. 1st time: Encounter with Ancient knight crashed game attempts to load game caused crash immediatly. 2nd time: Putting a Cryomancer in a Ars nouveau containment jar and breaking it caused crash. World can be loaded and a new attempt at breaking crashes the game again.

Steps to reproduce:

  1. New world.
  2. Ars containment ritual a cryomancer
  3. Break (in Survival) Jar with cryomancer

Server Type

Single Player Crashlog

https://pastebin.com/D0hD2vNx

Other mods

irons_spellbooks-1.21-3.4.4-all.jar
caelus-neoforge-7.0.0+1.21.jar curios-neoforge-9.0.5+1.21.0.jar
geckolib-neoforge-1.21-4.5.8.jar
player-animation-lib-forge-1.0.2-rc1+1.21.jar
neoforge-21.0.167-universal.jar
jei-1.21-neoforge-19.8.2.99.jar
ars_nouveau-1.21.0-5.0.7-all.jar

Notes: I don't think Ars or Geckolib are at fault as even without the containment jat the crash happened. And breaking a jar with Occultism mobs (that use geckolib) have not caused a crash yet.

Temporary fixes: When encountering the 1st type of crash, using a 3rd party tool like MCA Selector to delete chunks with crashing iron entites lets you load the world again. (At least it worked after deleting all of my nether chunks) When encountering the 2nd type of crash, using the mekanism cardboard box let's you move the jar.

iron431 commented 4 weeks ago

This is a known issue with geckolib and glowing entities

Syndrous commented 4 weeks ago

@iron431 are you referring to the issue I'm having or the second issue posted by Sloner42?

If it's the issue I'm having is there a solution in the works on their end that you've been made aware of? I'm curious because at this point its making the game unplayable. I encounter it within an hour or so each time I start a new world. I was mining and accidentally went under a village and got it this morning. The only corrective action I can think of is to disable village generation or disable mob spawns for all glowing mobs.

iron431 commented 4 weeks ago

generally, all bufferbuilding issues track down to the same root problem with geckolib. it is in the works of being fixed but requires rewriting a lot of their backend. glowing is one known cause, although it sounds like ars nouveau also can trigger it when a mob in contained in a jar. ultimately, it is a finicky issue and a result of the general instability of modded 1.21

Syndrous commented 4 weeks ago

Awesome, thanks for the update, I imagine the ATM team is tracking but if they are not, I'll update my issue over there so that they are aware.

Nirwine commented 1 week ago

Did you solve it? I have the same problem