iron431 / irons-spells-n-spellbooks

Other
80 stars 63 forks source link

[Bug] [1.21.1] v3.8.1 Not compatible with 21.1.60+ w/ Apothic Attributes #633

Open CubeTwo opened 1 month ago

CubeTwo commented 1 month ago

Observed behaviour

client don't launch image

Expected behaviour

client launch

Steps to reproduce

start game

Server Type

Single Player

Crashlog

https://gist.github.com/CubeTwo/59bb034b5689eb87bae2fec89472b755

Iron's Spells N Spellbooks version

irons_spellbooks-1.21-3.8.1

Forge version

NeoForge: 21.1.69

Other mods

No response

SiverDX commented 1 month ago

seems related to https://github.com/iron431/irons-spells-n-spellbooks/commit/ea9ebc19ef60abbf336ebb5d6c9009c470ab3952#diff-b807ea754fbd2a29f6b66dfa1ca722f95fb8e56fa4d9af18808cf07273bebfbdR28

the referenced attribute tooltip has been removed from apothic attributes in 2.4.0 and was added to neoforge itself

see:

https://github.com/neoforged/NeoForge/blob/1.21.x/src/main/java/net/neoforged/neoforge/common/extensions/IAttributeExtension.java

and default percentage attribute implementation:

https://github.com/neoforged/NeoForge/blob/1.21.x/src/main/java/net/neoforged/neoforge/common/PercentageAttribute.java

VaporeonScripts commented 1 month ago

got same error

iron431 commented 1 month ago

looks like 3.8.1 isnt compatible with latest 1.21.1. You could try with neoforge 21.1.57 and a corresponding downgrade of apothic attributes

VaporeonScripts commented 1 month ago

looks like 3.8.1 isnt compatible with latest 1.21.1. You could try with neoforge 21.1.57 and a corresponding downgrade of apothic attributes

not possible, most mods require .66/68 or superior, iron spellbooks should adapt to neoforge attributes update i think?

iron431 commented 1 month ago

that is the long term solution, but if you want to use the update right now on 1.21.1, you have to configure the versions

VaporeonScripts commented 1 month ago

ima just use the old version of iron spellbook

iron431 commented 1 month ago

compat has been temporarily removed in 3.8.2, alleviating the issue