iron431 / irons-spells-n-spellbooks

Other
77 stars 60 forks source link

[Bug] Incompatibility with Eternal Starlight (MC 1.21.1) #654

Closed uhloin closed 1 week ago

uhloin commented 1 week ago

Observed behaviour

Evoker Fort structure is generated in the abnormal dimension (from Eternal Starlight mod)

Expected behaviour

No Iron's structures in irrelevant dimensions

Steps to reproduce

Enter to Starlight dimension as instructed on the main page https://www.curseforge.com/minecraft/mc-mods/eternal-starlight

Server Type

Single Player

Crashlog

No response

Iron's Spells N Spellbooks version

1.21-3.8.4

Forge version

Neoforge 21.1.68

Other mods

eternalstarlight-0.1.17+1.21.1+neoforge.jar

Crashlog Check

iron431 commented 1 week ago

this is due to eternal starlight biomes being added to tags used for structure generation, such as "desert". i do not believe this is correct practice on their part, so I will not do anything about it

uhloin commented 1 week ago

I've sent a link to this explanation to Starlight developer here: https://github.com/LeoMinecraftModding/eternal-starlight/issues/24