iron431 / irons-spells-n-spellbooks

Other
80 stars 61 forks source link

[Bug] Griefing #673

Closed BazZziliuS closed 2 days ago

BazZziliuS commented 4 days ago

Observed behaviour

I think you won't do it, but I have to try I have a server where I use your mod and we play and have fun, but spells don't check if they can come from a fake player so that the private territory check works Why do players kill other players in a place where it is not allowed

Expected behaviour

I hope you can add checks for everything that can kill or break territory or build on it like portals

Steps to reproduce

It's trivial to put a portal on the private territory of World Guard or FTB Chunks

Server Type

Dedicated Server

Crashlog

No response

Iron's Spells N Spellbooks version

irons_spellbooks-1.20.1-3.4.0

Forge version

Forge: 47.3.10

Other mods

https://paste.fuix.net/RPo3hte

Crashlog Check

iron431 commented 3 days ago

sorry, can you explain the issue? what is strictly not working

BazZziliuS commented 3 days ago

извините, можете ли вы объяснить проблему? Что именно не работает?

Check for private territory Spells can be used where the player is not a participant or owner of the region

lab3 commented 2 days ago

What does "private territory" mean? This is not a vanilla feature. Is this compatibility with a specific mod? We can't do anything if you don't provide the full details of your issues including your specific configuration and reproduction steps.

BazZziliuS commented 2 days ago

Private territory is a place where the player who has privated it can use it, and PvP is disabled in it, as well as the ability to break blocks for players who are not included in the list of participants in the territory.

As an example, there is such a plugin https://dev.bukkit.org/projects/worldguard or mod https://www.curseforge.com/minecraft/mc-mods/ftb-chunks-forge

lab3 commented 2 days ago
  1. Please provide the EXACT mod you are using not examples of mods that are like it.
  2. Provide the configuration for that mod
  3. Provide the EXACT set of steps to reproduce the problem.
BazZziliuS commented 2 days ago

I use https://dev.bukkit.org/projects/worldguard Just lock the territory and let another player who is not in your private conjure a portal and it will appear although it should not because this player is not in your region and he does not have access to it A similar situation with other spells

BazZziliuS commented 2 days ago

I understood from our communication that you did not play on servers where there are privates, but believe me that the problem is quite serious since it destroys what it should not or damages

iron431 commented 2 days ago

we do not support plugins

BazZziliuS commented 2 days ago

Just specify checks from the fake player if you cast or install something, and the plugin will handle it itself