ironSource / parquetjs

fully asynchronous, pure JavaScript implementation of the Parquet file format
MIT License
348 stars 175 forks source link

Add support for deeply nested schemas #126

Open MarkOSIndustries opened 3 years ago

MarkOSIndustries commented 3 years ago

The previous reader implementation made the assumption that the next num_children schema elements were all that was required to reconstruct a given element.

This assumption broke down when faced with multiple levels of nesting.

I've added some failing integration tests and then applied a fix to decodeSchema, which makes them pass. I added the extra schema.js test purely for completeness, it passed fine without alteration.