If there is an error in transform -> pass error to callback

ironSource / parquetjs

fully asynchronous, pure JavaScript implementation of the Parquet file format

MIT License

349 stars 176 forks source link

If there is an error in transform -> pass error to callback #46

Open ZJONSSON opened 6 years ago

ZJONSSON commented 6 years ago

closes https://github.com/ironSource/parquetjs/issues/45

The error will in turn be emitted as an error event

ed-sparkes commented 4 years ago

Any chance this can be merged?

emranuddin75 commented 4 years ago

Its a useful change to merge in, and would be very much appreciated to capture the rejection rather than silently dying. Let me now when that would likely to be merged so that i can harden the code.

samsullivan commented 4 years ago

Ideally errors would be Error objects, not a string; but, I agree, anything merged would be a welcomed improvement.

sambonbonne commented 3 years ago

Hello, I am facing an issue with the unhandled rejection, is it possible to merge this PR?