Closed jeffbski closed 5 years ago
LGTM @kessler
Is there any chance this (or #79) will get merged into master? We were getting errors when using this on AWS Lambda, because LZO needs to be compiled for Lambda's architecture. Applying this PR resolved it :)
I'll take a look at this over the weekend.
In the meantime please sign the cla agreement here: https://github.com/ironSource/opensource-contributor-license-agreement
Thanks!
On Sun, 22 Sep 2019 at 20:28, Adam Dabbracci notifications@github.com wrote:
Is there any chance this (or #79 https://github.com/ironSource/parquetjs/pull/79) will get merged into master? This is the only thing preventing us from deploying our new Parquet-based reporting :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ironSource/parquetjs/pull/80?email_source=notifications&email_token=AABD7J4H3Z2ESVZ6S6IUW4DQK6TMTA5CNFSM4G4HYJNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7JK5EI#issuecomment-533900945, or mute the thread https://github.com/notifications/unsubscribe-auth/AABD7J5W4ARTA6YOIQOGDULQK6TMTANCNFSM4G4HYJNA .
I uploaded signed cla agreement here: https://github.com/ironSource/opensource-contributor-license-agreement/issues/2
published v0.11.0
I can close #79 now right?
yes, #79 was an alternate approach. Thanks!
You guys are awesome. Thanks!
This is an alternative approach to #79 based on @vweevers comment.
Since lzo requires a native compilation step as part of its install make lzo an optional dependency that is only required when it is that feature is attempted to be used. We hide lzo behind a function.