search

ironSource / parquetjs

fully asynchronous, pure JavaScript implementation of the Parquet file format
MIT License
346 stars 175 forks source link

Fix support for negative timestamps #89

Open alfaproject opened 4 years ago

alfaproject commented 4 years ago

In the date conversion methods negative dates are not support and that doesn't allow to have people that were born before 1970 in our database.

Example: https://github.com/ironSource/parquetjs/blob/master/lib/types.js#L300

We created a patch to remove the negative check but it would be good to have it done here.

dobesv commented 4 years ago

Did you submit that change as a pull request?