search

ironarachne / namegen

A library and CLI program for generating random names, written in Go.
Apache License 2.0
33 stars 29 forks source link

Add Irish names #83

Closed BenOvermyer closed 1 year ago

BenOvermyer commented 1 year ago

Add Irish names to the generator.

See https://en.wikipedia.org/wiki/Irish_name

NevilleMthw commented 1 year ago

Hi, are the names in that link enough or would https://en.wikipedia.org/wiki/List_of_Irish-language_given_names be better?

Thanks, Neville

BenOvermyer commented 1 year ago

@NevilleMthw The latter would be better.

If you're planning on doing this for Hacktoberfest, remember that you have to wait to submit the PR until October 1!

NevilleMthw commented 1 year ago

Oh okay, I have never participated in the event before but I guess I will just submit the PR on October 1st which would count towards the contribution.

NevilleMthw commented 1 year ago

@BenOvermyer For the Irish names, do you want only the native names of both genders or the foreign ones as well?

BenOvermyer commented 1 year ago

Native, preferably.

NevilleMthw commented 1 year ago

Do you need Irish last names? If so, I found a link: Irish Gaelic Surnames. Let me know if this is fine or not needed.

BenOvermyer commented 1 year ago

@NevilleMthw Yeah, last names are needed. Good link!