search

ironarachne / namegen

A library and CLI program for generating random names, written in Go.
Apache License 2.0
33 stars 29 forks source link

Add Nigerian names #97

Closed BenOvermyer closed 11 months ago

BenOvermyer commented 12 months ago

Add Nigerian names to the generator.

RaturiAR7 commented 12 months ago

I would like to work on this.

BenOvermyer commented 12 months ago

@RaturiAR7 Alright, I'll assign it to you.

RaturiAR7 commented 11 months ago

@BenOvermyer I have created a pull request for the issue. I am a beginner to open source and wanted to participate in hactoberfest. Please let me know if any changes are to required.

RaturiAR7 commented 11 months ago

@BenOvermyer I thought this repo was participating in hacktoberfest but my PR with nigerian names did not count.

BenOvermyer commented 11 months ago

@RaturiAR7 It takes seven days after a PR is merged for it to be accepted for Hacktoberfest. See the rules here: https://hacktoberfest.com/participation/

RaturiAR7 commented 11 months ago

@BenOvermyer Yes, I know it takes seven days but it also won't count if my PR was not labelled as hacktoberfest and hacktoberfest accepted. I think you did not label it as hacktoberfest and hacktoberfest accepted before merging my PR that's why it not appearing in my hactoberfest profile. All of my other contributions are showing in profile with a timer of 7 days from the day of getting merged.

BenOvermyer commented 11 months ago

One of two things must be true - either the repository has to have the topic hacktoberfest or the PR has to have the label hacktoberfest-accepted. This repository has the topic hacktoberfest. I submitted (and merged) a PR to this repo earlier and got credit for the PR.

I'll take another look at your PR and see if there's anything unusual about it that would cause you to not get credit.

RaturiAR7 commented 11 months ago

Ok sir