search

ironarachne / world

This is a fantasy world generation CLI and set of Go packages for the same.
MIT License
48 stars 9 forks source link

Add all missing weapons from the D&D 5E player's handbook #9

Closed BenOvermyer closed 4 years ago

BenOvermyer commented 4 years ago

The weapons resources are listed here: https://github.com/ironarachne/world/blob/master/pkg/resource/weapons.go

This list should include at least one pattern for every weapon in the Dungeons & Dragons fifth edition Player's Handbook.

BenOvermyer commented 4 years ago

Relevant list here: http://www.5esrd.com/equipment/weapons/

tpaschalis commented 4 years ago

Hi! I'd like to start working on this if it's okay! What should the "Value" field of the Pattern struct hold?
Should it be the cost, weight, or just a dummy value that will be edited later on?

BenOvermyer commented 4 years ago

@tpaschalis The Value is meant to be the cost, but right now it's only a rough estimate. A future iteration will focus on pricing and currency.

tpaschalis commented 4 years ago

Okay. For starters, I'll be using the Gold Piece and Silver Piece prices from the PHB, with 10:1 currency ratio.

BenOvermyer commented 4 years ago

Okay. For starters, I'll be using the Gold Piece and Silver Piece prices from the PHB, with 10:1 currency ratio.

Sounds good.

sumitb commented 4 years ago

@tpaschalis Are you still working on it, if not I would like to take a stab at this issue cc @BenOvermyer

tpaschalis commented 4 years ago

Unfortunately this week I won't have the bandwidth to close the issue. Feel free to take it on if you want, and/or use the work I've currently done to close it. It shouldn't be more than half an hour of work. Best of luck!

BenOvermyer commented 4 years ago

@tpaschalis Thanks for your work on this! I think you'll still get credit for Hacktoberfest if this PR is merged before the end of the month.