ironbane / IronbaneServerLegacy

A 3D MMO written using pure javascript.
http://www.ironbane.com/
GNU General Public License v3.0
175 stars 44 forks source link

Develop unitlist object #408

Closed ingmargoudt closed 10 years ago

ingmargoudt commented 10 years ago

The unitlist is changed to a separate object (could be a service later), all other classes dont affect the unitlist directly, but modify and query the contents with mutators and accessors. e.g.: ironbane.unitList.push(new Unit()) vs ironbane.getUnitList().addUnit(new Unit());

bsparks commented 10 years ago

Looks good accept

markfarrell commented 10 years ago

/src/client/game/js/Game/Player.js Line 606:

Are you sure "_.each(ironbane.getUnitList().iterate(function() { ... }));" is not supposed to be "ironbane.getUnitList().iterate(function() { ... });" ?

ingmargoudt commented 10 years ago

Correct. Should be without the _.each() as that is called by the unitlist.iterate() function itself. Will update and commit.

Verstuurd vanaf mijn iPhone

Op 22 dec. 2013 om 20:01 heeft markfarrell notifications@github.com het volgende geschreven:

/src/client/game/js/Game/Player.js Line 606:

Are you sure "_.each(ironbane.getUnitList().iterate(function() { ... }));" is not supposed to be "ironbane.getUnitList().iterate(function() { ... });" ?

— Reply to this email directly or view it on GitHub.

markfarrell commented 10 years ago

Accept