Fix: Imported workbooks should use the file name as title

ironcalc / IronCalc

Main engine of the IronCalc ecosystem

Apache License 2.0

62 stars 2 forks source link

Fix: Imported workbooks should use the file name as title #111

Closed dg-ac closed 1 day ago

dg-ac commented 3 days ago

This one is self explanatory. At the moment, the workbook title is generated by IronCalc:

Ideally, we should use as title the name of the file updated.

nhatcher commented 2 days ago

Fixed, please test

dg-ac commented 2 days ago

Fantastic. Works for me.

dg-ac commented 2 days ago

Sorry, reopening. I feel the extension (.xlsx, for example) shouldn't be part of the title. If I import a worksheet called file.xlsx and download it again, the name of the new file will be file.xlsx.xlsx, which feels odd. What do you think?

nhatcher commented 2 days ago

True, fixed.

dg-ac commented 1 day ago

LGTM!