search

ironcamel / DBICx-Sugar

Just some sugar for DBIx::Class
2 stars 1 forks source link

FTBFS: test failure in t/06-replicated.t: DBIx::Class 0.082842 needs Clone #6

Open gregoa opened 2 years ago

gregoa commented 2 years ago

We have the following bug reported to the Debian package of DBICx-Sugar, c.f. https://bugs.debian.org/996258

It doesn't seem to be a bug in the packaging, so you may want to take a look. Thanks!

------8<-----------8<-----------8<-----------8<-----------8<-----

Source: libdbicx-sugar-perl
Version: 0.0200-1
Severity: serious
Tags: ftbfs bookworm sid
Justification: fails to build from source

As noticed on ci.debian.net, the package's testsuite fails, and does
so also during build in a sid chroot:

DBIx::Class::Schema::catch {...} (): Unable to load storage class DBIx::Class::Storage::DBI::Replicated: {UNKNOWN}: The following modules are required for Replication Clone (see DBIx::Class::Optional::Dependencies for details)
BEGIN failed--compilation aborted at /usr/share/perl5/DBIx/Class/Storage/DBI/Replicated.pm line 7.
Compilation failed in require at /usr/share/perl5/Class/C3/Componentised.pm line 146. at /usr/share/perl5/Class/C3/Componentised.pm line 151 at /build/libdbicx-sugar-perl-0.0200/blib/lib/DBICx/Sugar.pm line 118
t/06-replicated.t ........ 
1..8
ok 1
ok 2
ok 3 - no (unexpected) warnings (via END block)
Dubious, test returned 2 (wstat 512, 0x200)
Failed 5/8 subtests 

Test Summary Report
- -------------------
t/06-replicated.t      (Wstat: 512 Tests: 3 Failed: 0)
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 8 tests but ran 3.
Files=6, Tests=22,  2 wallclock secs ( 0.03 usr  0.01 sys +  1.54 cusr  0.13 csys =  1.71 CPU)
Result: FAIL
Failed 1/6 test programs. 0/22 subtests failed.
make[1]: *** [Makefile:871: test_dynamic] Error 2

Not sure which reverse build dependency changed. No upstream bug
report available yet.

Maybe libdbix-class-perl/0.082842-1?
Oh yes, tracker agrees:
https://tracker.debian.org/pkg/libdbix-class-perl

And the fix is simple: libclone-perl is needed

Cheers,
gregor, preparing an upload

------8<-----------8<-----------8<-----------8<-----------8<-----

Thanks for considering, gregor herrmann, Debian Perl Group

ironcamel commented 2 years ago

And the fix is simple: libclone-perl is needed

@gregoa I'm not sure I follow. Are you saying that I need to add https://metacpan.org/pod/Clone as a dependency?

gregoa commented 2 years ago

Yes, I think so, at least as a test requirement. DBIx::Class says in the Changes file for the 0.082842 release:

        - Work around breakage in Hash::Merge by soft-requiring Clone as part
          of the replicated subsystem (RT#124321)

and apparently t/06-replicated.t hits this code path which needs Clone.