search

ironcamel / Dancer-Plugin-Email

Simple email sending for Dancer
http://p3rl.org/Dancer::Plugin::Email
6 stars 10 forks source link

Dancer 2 compatibility #13

Closed sukria closed 11 years ago

sukria commented 11 years ago

This patch allows your module to run with both Dancer 2 and Dancer 1.

Can you review the changes and build a new release for CPAN?

Thanks a lot.

ironcamel commented 11 years ago

Thanks Alexis, but this is not going to work because you patched a very old version of this module. You should do a git pull.

sukria commented 11 years ago

Oh sorry. Ill do that.Envoyé depuis un mobile Samsung Naveed Massjouni a écrit :Thanks Alexis, but this is not going to work because you patched a very old version of this module. You should do a git pull.

          —
          Reply to this email directly or view it on GitHub.
sukria commented 11 years ago

Here it is.

sukria commented 11 years ago

Here it is.

For information, this last version is broken while the one I was using was working, after a pull I now have the following error (while it was working just fine before):

error when closing pipe to sendmail

Trace begun at /home/alexis/perl5/perlbrew/perls/perl-5.12.2/lib/site_perl/5.12.2/Email/Sender/Transport/Sendmail.pm line 79
Email::Sender::Transport::Sendmail::send_email('Email::Sender::Transport::Sendmail=HASH(0x637f428)', 'Email::Abstract=ARRAY(0x63bc098)', 'HASH(0x6518f90)') called at /home/alexis/perl5/perlbrew/perls/perl-5.12.2/lib/site_perl/5.12.2/Email/Sender/Role/CommonSending.pm line 27
ironcamel commented 11 years ago

This is no longer relevant since it was decided that Dancer2 is going to live on its own.