search

ironcamel / vimchat

XMPP Chat for vim
84 stars 11 forks source link

VimChat thread exit, new features and some improvements #1

Closed philsmd closed 13 years ago

philsmd commented 13 years ago

New VimChat exit handler. New customizable options like blink timeout, buddy list max width, custom time format etc. Several improvements

ironcamel commented 13 years ago

This is a great patch. Thanks for fixing the exit bug. Also, thanks for the nice features you added. Just one thing. In the future, please provide each bug fix or feature as a separate pull request.

philsmd commented 13 years ago

yes I will do that. I was unsure how to do that with so may changes within a file. But I will try next time, I promise. Please check if the exit bug fix of VimChat works also for you. Thanks ~Phil

ironcamel commented 13 years ago

It is very easy actually. Just make a separate branch for each feature. This is a good practice anyway. Then request a pull for each branch separately.

Of course I tested the bug fix :) If it didn't work, I wouldn't have pulled your patch.