search

ironcamel / vimchat

XMPP Chat for vim
84 stars 11 forks source link

Pr/gvim crash fix #12

Closed philsmd closed 12 years ago

philsmd commented 13 years ago

This resolves a gvim SEGV on my machine. It is a fix that needs to be tested on other machines and we need to understand the main cause why those imports are not allowed in gvim

throughnothing commented 13 years ago

Hey great job cleaning up and re-doing these pull requests, I really appreciate it. This one looks perfect, thanks!

ironcamel commented 12 years ago

@philsmd, thanks a lot for this patch. vimchat finally works in gvim for me now, hooray. But it is still very unstable for me. After a few messages, gvim crashes. I'm using vim/gvim version 7.3.254. phil, have you had a similar experience, or is it stable for you? Either way, I'm still going to pull this. Thanks!

philsmd commented 12 years ago

Hi ironcamel,yes I have experienced also some additional problems w/ gvim that may be unrelated to the fix.We need to test it further to check what exactly causes these crashes.I'm not using gvim very often,I prefer using vim,but I will test a little bit,maybe I can find the problem.

ironcamel commented 12 years ago

Thanks @philsmd!