ironcamel / vimchat

XMPP Chat for vim
84 stars 11 forks source link

Not opening chat buffer #20

Closed golodhrim closed 12 years ago

golodhrim commented 13 years ago

first list is shown as {{{ NAME JID ..... }}}

and not as (Status) NAME

second if I wanna start a chat I get the following error:

Traceback (most recent call last):
File "", line 1, in File "", line 983, in beginChatFromBuddyList File "", line 1060, in beginChat KeyError: 'user@server'

what is it or how can one fix it... :)

ironcamel commented 13 years ago

Can you provide a little more detail. What do you mean by "start a chat"? What exactly are you doing?

golodhrim commented 13 years ago

I can, so how I got this is:

  1. starting vim by typing vim on the console
  2. when vim is started typing in Command mode :VimChat<CR>
  3. typing B in Command mode to open Buddylist
  4. navigating with the arrow keys to a person to chat to and pressing <CR>

I guess so far that is the right procedure, what I get is a Traceback (most recent call last) error

in 3 I get the showing of the {{{ INFO }}} list already. That's all I did, and nothing more :)

blacklight commented 12 years ago

I experienced exactly the same issue

golodhrim commented 12 years ago

ok, BlackLight, did you solve it, and if yes how? would be nice to know where I did the error...

blacklight commented 12 years ago

The steps to reproduce it are exactly the same as yours, and the error is the same as well. Anyway I didn't manage to fix it. Any feedback from the developers would be great, because this issue makes Vimchat simply unusable.

ironcamel commented 12 years ago

Sorry for taking so long to respond. I have some idea why this is happening. Can you guys provide me with the first line in your buddy list window. It should have your jabber id in it. For me, the first line is: {{{ [+] naveedm9@gmail.com

golodhrim commented 12 years ago

so here the first line and the starting of line 2 look like that:

1 {{{ [+] golodhrim@jabber.ccc.de                              
2 {{{ (away) user@server.tld
3     user@server.tld
4     Groups: [u'group']
5     away:
6 message
7 }}}

so what do you guess is the reason for it? something wrong configured?

ironcamel commented 12 years ago

@golodhrim, thanks to stacktrace you provided in the original ticket, I have tracked down the bug to the following. I cache all the connections corresponding to each account you have configured in your ~/.vimchat/config file inside the attribute self.accounts. This is a dictionary keyed by account names, where account name means your jabber id. When you hit enter on someone's name to start chatting with them, the first thing that happens is the connection object is retrieved from this dictionary. In your case, an exception occurs because that key does not exist inside the dictionary. The reason I asked you for the first line in your buddy list buffer is because the way the account is found (this is very hacky, I know) is by traversing up the vim folds in the buddy list buffer and parsing your jabber id with the following code: account = str(vim.current.line).split(' ')[2] . My guess was that maybe you had a weird jabber id that would break that code. For example if your jabber id somehow had a space in it or something. Or the first line in your buddy list buffer was somehow malformed. But based on your response, it looks fine. I'm going to keep looking into this. I'll try to fix this as soon as possible. Thank you for staying engaged and helping me with this.

ironcamel commented 12 years ago

@golodhrim I was able to reproduce this error in the following way: 1) type B to bring up buddy list 2) type Enter button right away (before expanding the folds)

Can you try the following steps and tell me if you still get the error: 1) type B to bring up buddy list 2) type zr to expand the folds 3) move cursor DOWN to a person's name 4) type Enter

If you still get an error, can you copy and paste me the exact error. Especially, I need to know if the error line that starts with 'KeyError:' is complaining about the jabber id of a buddy or about the name of your jabber account.

golodhrim commented 12 years ago

@ironcamel if I follow you steps, I get from the beginning a list that is expanded like

{{ [+] golodhrim@jabber.ccc.de
   {{ (on) nick@jabber-server.tld
      nick@jabber-server.tld
      Groups:[u'groupname']
      on:
      message
   }}
}}

and the the error is

Traceback (most recent call last):
   File "<string>", line 1, in <module>
   File "<string>", line 983, in beginChatFromBuddyList
   File "<string>", line 1060, in beginChat
KeyError: 'nick@jabber-server.tld'
Press ENTER or type command to continue

That's what I get, and the same is for a collapsed list and it makes no difference if I go on the nick or the jid. So perhaps I'm doing something totally wrong then? but I don't know what...

ironcamel commented 12 years ago

@golodhrim what version of vim you are using?

golodhrim commented 12 years ago

@ironcamel vim version is 7.3.444

ironcamel commented 12 years ago

@golodhrim I added a fix just for you :) Please update your local repo by doing a git pull. Then try again and let me know if this fixes your issue. Please make sure you are running the latest code. Thanks!

golodhrim commented 12 years ago

@ironcamel yep thanks that fixed the issue... awesome, thanks for the fast help since you reacted :) I already thought it wouldn't work for me ever, but that is just awesome... :) really great. can only give my advice for others to try it if they have time and can now replace my mcabber with vim... :) nice stuff for development now, one can work and at the same time see when a new message arrives, no more need for two windows or a splitscreen with tmux for it... :)

ironcamel commented 12 years ago

@golodhrim thanks for your patience and help in troubleshooting this. Since you are someone new to using vimchat, I would be interested in your opinion about the intuitiveness of the built in commands. Or about the usefullness of the documentation for new users. Feel free to create new tickets to address these issues, if you have any suggestions.

golodhrim commented 12 years ago

@ironcamel thx will do so mailed you also about a feature request, so let me know what you think about it...