Added a few features - Githubissues

ironcamel / vimchat

XMPP Chat for vim

84 stars 11 forks source link

Added a few features #29

Closed kaHaleMaKai closed 8 years ago

kaHaleMaKai commented 8 years ago

Hi Naveed,

first of all: vimchat – I love it. But I missed some features like

reloading logs on demand when scrolling beyond line 1
syntax highlighting for messages (e.g. emoticons)
ability to change syntax highlighting via global variables

Moreover, I restructured the plugin using the autoloading.

If that's too much for a single pull request, I get it – but it was just fun to work on it, though. That's why I just kept adding stuff ;-)

Have a great day! Best, Lars

ironcamel commented 8 years ago

Hi Lars. Thanks for the pull request, but this is impossible for me to review. If you would like to split this up into multiple smaller pull requests, I would be glad to take a look. Thanks!

kaHaleMaKai commented 8 years ago

Hi Naveed,

thought so…too bad I didn't split it up in the first place. I will be off from work by mid of February. I will then try to present it to you in a more digestable version :-)

Best, Lars

On 05.02.2016 07:11, Naveed Massjouni wrote:

Closed #29 https://github.com/ironcamel/vimchat/pull/29.

— Reply to this email directly or view it on GitHub https://github.com/ironcamel/vimchat/pull/29#event-540261789.