ironcev / Pragmatic

[The description is yet to come]
5 stars 3 forks source link

Need ModernUI Patches through NuGet. #7

Closed vipyadav closed 10 years ago

vipyadav commented 10 years ago

Hi Igor,

I have found that ModernDialog.ShowDialog() always returning false. And then I have started investigation about this and found that it is the bug in ModernUI code and now they have fixed it and releases patches.

The link of patches given below: http://mui.codeplex.com/SourceControl/changeset/101528

But these patches are not merged by NuGet so what should we do?

Meanwhile I have overload the ModernDialog buttons for workaround.

Thanks & BR, Vipin

ironcev commented 10 years ago

Hi Vipin,

If I understood you well, your workaround is functional and fixes the problem. If it is so, I would rather wait for the NuGet package and live with the workaround than have binaries checked in in the Vendors folder. The Vendors folder is just a fallback for libraries that do not have NuGet packages. We should avoid using it.

Anyhow, we should kindly ask ModernUI contributors to publish new NuGet packages. In my opinion this is a serious bug that makes the dialogs hardly usable for anything else than displaying values.

Can you contact them regarding that?

What I find strange is the following. The patch (your link) is done on 6. June 2013 and the NuGet package for ModernUI 1.0.5 (https://www.nuget.org/packages/ModernUI.WPF/) is published on 7. July 2013. How comes that the fix is not in the package?

BR Igor

vipyadav commented 10 years ago

Hello Igor,

Yes you are right.I think, may be NuGet does not want to use patches and they only want to use complete releases.But I am not sure.

Regarding the communication with ModernUI,there are already threads running regarding this issue. I am giving you the links.Please suggest.

http://mui.codeplex.com/discussions/449700 http://mui.codeplex.com/workitem/20096

BR, Vipin

ironcev commented 10 years ago

Hi Vipin,

Thank you for investigating the issue in depth. I posted comments on both of the discussion threads on CodePlex. Hopefully we will got new release.

Meanwhile, can you explain shortly how your workaround works. Can we live with it so far?

BR Igor

ironcev commented 10 years ago

Ups, closed by mistake :-)

vipyadav commented 10 years ago

Hi Igor,

Yes we can live with this workaround.

I have just created dialog without any buttons.

var userProfileDialog = new UserProfileDialog { Title = "Edit Profile", Buttons = new Button[] { } };

Then I have created own OK and Close button on dialog and binded with commands. The code is pushed into my repository also.

BR, Vipin

ironcev commented 10 years ago

Hi Vipin,

This is an acceptable workaround and you commented on it in code as well. Let's leave it for now as it is and wait for the patch.

I will close this issue.

BR Igor