search

ironcore-dev / dpservice

DPDK based fast Dataplane / L3 router / SDN enabler, installable on compute nodes / SmartNICs
Apache License 2.0
7 stars 1 forks source link

Remove 'Build and Publish Docker Image' from PR actions #561

Closed PlagueCZ closed 5 months ago

PlagueCZ commented 5 months ago

Removes an unnecessary and long "docker image build" action from PRs. The tester image already builds the same binary (along with others) and runs all tests.

The action will still be run for any push to main branch and for manual actions.

PlagueCZ commented 5 months ago

The first part of the intended change does work, only the tester image has been built (and successfully tested).

As for the second part (still working for main), that remains to be seen.

I have read only the documentation on the on keyword (not the whole "actions" documentation), which led me to simply remove the on: pull_request section to prevent the build on PRs. Then I saw multiple places testing whether or not the action has been run via this pull_request event, so I removed those too.

Hopefully I have not missed anything.