ironcore-dev / dpservice

DPDK based fast Dataplane / L3 router / SDN enabler, installable on compute nodes / SmartNICs
Apache License 2.0
7 stars 1 forks source link

Proper fix for version.h generation #570

Closed PlagueCZ closed 3 months ago

PlagueCZ commented 3 months ago

There was still one issue with dp_version.h generation. When changing something not related to dpservice-bin and creating a new commit, the commit-id changes, dp_version.h is regenerated, but dpservice-bin does not get rebuilt.

This causes a problem in tests.

By fixing it (adding version.h as a source dependency for the executable, as per meson docs), this also fixes the strange behavior previously mentioned and solved by pre-generating the version header file in configuration step. This is now not needed.

There was also a wrong path to the new version getter script, but for some reason it still worked partially (?).