search

ironcore-dev / metalbond

Route reflector for IronCore Infrastructure Overlay Network
Apache License 2.0
0 stars 1 forks source link

Update netlink to self-maintained latest version #100

Closed byteocean closed 8 months ago

byteocean commented 8 months ago

it would be nice to get rid of the package replacement for netlink. But before the maintainers of netlink respond to the new request to merge the change, it would be necessary to keep the self-maintained netlink lib up-to-date.

guvenc commented 8 months ago

Thanks @byteocean . Looks like the new version doesnt contain the commit which changes the go version in go.mod. (commit id: 1ca7c35) When you are at it, the go version can be bumped to 1.21 in this self maintained repo as well.

The functionality we use in this netlink library somehow (re-)tested after being rebased to its upstream main branch ? I see that you have a test case in the self maintained repo exercising this part, I assume that it was run successfully ?

byteocean commented 8 months ago

This corresponding change is now merged to the upstream netlink, but a new release still needs to be published by them. before that, the package needs to point to the version where the commit gets merged. We can finally get rid of the package replacement statement.

guvenc commented 8 months ago

Great news !!