search

ironcore-scrapyard / dpservice-go

Golang bindings for the dpservice
Apache License 2.0
0 stars 1 forks source link

conform to the uint32 type defined in dp-service for Status code #40

Closed byteocean closed 1 year ago

byteocean commented 1 year ago

As it is defined in the proto file in dp-service main branch, the code field is uint32 instead of int32, thus the relevant proto files are recompiled to conform to this change.

byteocean commented 1 year ago

@vlorinc Could you check if this change would break things as you are actively working on it?

vlorinc commented 1 year ago

@byteocean I changed the types of errors.Ignore function to uint32 as it needs to be of same type. Other than that it looks OK.

byteocean commented 1 year ago

@vlorinc thanks a lot. then I make it an official PR.