irondash / cargokit

Integrate cargo build with flutter plugins and applications.
Other
51 stars 16 forks source link

chore: support build as a flutter module #70

Closed jifang closed 3 weeks ago

jifang commented 1 month ago

When build as a flutter module and integrated into the existing android project, there is no applicationVariants and result in following compilation failure:

Could not get unknown property 'applicationVariants' for extension 'android' of type com.android.build.gradle.LibraryExtension.

In such case, we will use libraryVariants instead

https://github.com/superlistapp/super_native_extensions/issues/379

jifang commented 1 month ago

Not an expert on github action CI.

From the error message

[        ] > BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 65

It seems the github action CI is using Java 21 (class version 65) and gradle 7.5 doesn't support it

The command to execute the gradle task is

[        ] Starting process 'Gradle build daemon'. Working directory: /Users/runner/.gradle/daemon/7.5 Command: /Users/runner/hostedtoolcache/Java_Temurin-Hotspot_jdk/21.0.3-9.0/arm64/Contents/Home/bin/java ... ...

Not sure why it is using JDK 21 as the workfile specifies the JDK11?

jifang commented 1 month ago

@knopp Could you take a look of this PR? I also managed to fix the workflow failure. https://github.com/jifang/cargokit/actions