search

ironexdev / zoom

Lightweight (8 Kb) ES5 javascript plugin without any dependencies, compatible with desktop and mobile devices.
https://zoom.by-ironex.com
Apache License 2.0
33 stars 13 forks source link

Doesnt work with new Chrome #1

Closed swarad07 closed 5 years ago

swarad07 commented 5 years ago

Hi I tried the latest library it doesn't work with new Chrome, works on FF and Safari.

An older version is linked here https://www.cssscript.com/touch-enabled-image-zoom-plugin-javascript/ and it works just fine.

Could you help with fixing the compatibility with Chrome?

jeremyrperry commented 5 years ago

@swarad07 I checked out your problem since it could be related to mine. I personally didn't have any issues with this library except for IE11. I might be able to help you if you can put up an example somewhere that's publicly accessible.

swarad07 commented 5 years ago

Hi @jeremyrperry, here is the public URL of what I am facing. You need to try this on mobile though, as on desktop this works just fine --even in mobile resolutions.

Link1: https://codepen.io/swarad07/full/yZoxJy

This pen has the library source from the master branch of this repo. This doesnt work. Tested on: Android 9 - Chrome 71.0.357 - OnePlus 6T

Link2: https://codepen.io/swarad07/full/QYMVLP

This pen has the source from https://www.cssscript.com/demo/touch-enabled-image-zoom-plugin-javascript/. This works just fine in all browsers, desktop as well as mobile.

swarad07 commented 5 years ago

Also on IE11 the ES6 syntax doesnt work for zoom function declaration.

If you change it to below where you initialize the arguments inside rather than inline as it should be for ES5, it works.

function zoom(classNames, settings) {
  var classNames = classNames || {};
  var settings = settings || {};
ironexdev commented 5 years ago

resolved by pull request by @jeremyrperry in https://github.com/ironexdev/zoom/issues/2