search

ironfede / openmcdf

Microsoft Compound File .net component - pure C# - netstandard 2.0
Mozilla Public License 2.0
302 stars 73 forks source link

Refactorings, code improvements and bug fixes #36

Open DevDrake opened 5 years ago

DevDrake commented 5 years ago

-Resharper Code Cleanup -Removed redundant code -Fixed issues in stream structure description(comment) -Removed usage of ArrayList in favor of List - yes it was used xD -Sorted some of the properties/methods in files -Improved readibility -Cleanup of usages -Fixed few bugs on the way -Improved execution time slighty -"Fixed" equals to do the same as other equal - yet it seems wrong.

Massive changes in general, get it for free or leave it. Leaving it as a token of gratitude.

It still works as before.

ironfede commented 5 years ago

Massive thanks @DevDrake , it will take some time to check all your work before merging, but meanwhile please let me kindly know what you have identified as "bug" (>>Fixed few bugs on the way) because I should give high priority to those changes that fixes functional errors. Thank You! Best Regards, Federico

DevDrake commented 5 years ago

Hi @ironfede, first, thanks for sharing the OpenMCDF with the community! Sorry for making all the changes in the single commit - I just didn't expect myself to contribute, yet i sow value so there it is. i have put the things i fixed in comments in the diff, there are some TODO added in the code, and some things that have been forgotten already. Again sorry, i wasn't tracking it until i found it will add the value to the projects. The formatting of the code has changed significantly, if you have specific guidelines i can modify the commit get them in the account, otherwise you got the JetBrains default guidelines for c# in this commit. Merry Xmas, Mikolaj