search

ironhacks / ironhacks-app

IronHacks server application built with React
https://ironhacks.com/
GNU General Public License v3.0
4 stars 2 forks source link

[BUG] Notebook viewer not working #145

Closed sbrunswi closed 2 years ago

sbrunswi commented 2 years ago

Summary When I use the dev platform or the live platform and try to open a notebook via our internal notebook viewer, the notebook is not loading! So that

Description

Steps To Reproduce

  1. Starting here: Log-in to dev and live (www.ironhacks.com)
  2. Do this action: Go to the tutorials and load an example notebook
  3. Then I get an error message saying that notebook cannot be viewed.

Expected behavior I should be able to see the notebook

Screenshots If applicable, add screenshots to help explain your problem.

Device Info

Browser

Supporting Files

ManthanKeim commented 2 years ago

All the notebook are fetched from GitHub using it's raw link, so one should be cautious of moving a notebook into archived folder or just change it's title, as it's change the ID linked with the IronHacks platform. I see @harshpavuluri moved the tutorials into the archived folder so they are not found on the platform.

harshpavuluri commented 2 years ago

Yup. I've been moving things around for the tutorials at least so the template was in there. Just need the new link is all

ManthanKeim commented 2 years ago

It's all good, it's not your fault, just how the notebook viewer works.

ManthanKeim commented 2 years ago

So I took them out of archive for now @harshpavuluri , because I'm not sure where else we use these links for tutorials, so can't change the schema for now. @sbrunswi all the notebook works as usual now.

sbrunswi commented 2 years ago

Yes. Important to keep in mind to update links. I can’t always track and monitor you. Be aware.

On Wed, Oct 5, 2022 at 1:26 PM Manthan Keim @.***> wrote:

It's all good, it's not your fault, just how the notebook viewer works.

— Reply to this email directly, view it on GitHub https://github.com/ironhacks/ironhacks-app/issues/145#issuecomment-1268722624, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7DAY5PLQ62GQPAS2XBPLLWBW25XANCNFSM6AAAAAAQ5WHXIM . You are receiving this because you authored the thread.Message ID: @.***>

sbrunswi commented 2 years ago

I think we should go through all pages and check links and reembedd. I always did this in the past. We should archive and reembed.

Sent from my iPhone

On Oct 5, 2022, at 1:27 PM, Manthan Keim @.***> wrote:

 So I took them out of archive for now @harshpavuluri , because I'm not sure where else we use these links for tutorials, so can't change the schema for now. @sbrunswi all the notebook works as usual now.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.