ironm73 / pyv8

Automatically exported from code.google.com/p/pyv8
0 stars 0 forks source link

setup.py problems on Windows #137

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I had to make the following changes to setup.py to get a good build on Windows:

I don't have MINGW installed, this diff allows for not having MSYSTEM set.

@@ -11,7 +11,7 @@
 is_mac = os.name == "mac"
 is_osx = os.name == "posix" and sys.platform == "darwin"
 is_cygwin = os.name == "posix" and sys.platform == "cygwin"
-is_mingw = is_winnt and os.environ.get('MSYSTEM').startswith('MINGW')
+is_mingw = is_winnt and os.environ.get('MSYSTEM', '').startswith('MINGW')

I installed boost with boostpro, which doesn't have a stage folder.  I think 
stage should be a part of BOOST_HOME, rather than built into the script.

@@ -181,7 +181,7 @@
     ]
     library_dirs += [
         V8_HOME,
-        os.path.join(BOOST_HOME, 'stage/lib'),
+        os.path.join(BOOST_HOME, 'lib'),
         os.path.join(PYTHON_HOME, 'libs'),
     ]

This is a known issue, documented in the v8 build instructions.  scons doesn't 
pick up the locations of newer versions of visual studio.  See: 
http://code.google.com/p/v8/wiki/BuildingOnWindows

@@ -379,6 +379,7 @@
             'liveobjectlist': 'on' if V8_LIVE_OBJECT_LIST else 'off',
             'disassembler': 'on' if V8_DISASSEMBLEER else 'off',
             'fasttls': 'on' if V8_FAST_TLS else 'off',
+            'env':  '"PATH:%PATH%,INCLUDE:%INCLUDE%,LIB:%LIB%"',
         }

         print "INFO: building Google v8 with SCons for %s platform" % options['arch']

Just thought you should know about these problems I experienced.

Original issue reported on code.google.com by artlo...@gmail.com on 10 Oct 2012 at 9:01

GoogleCodeExporter commented 8 years ago
Thanks very much, I have merged your patch @ r449 :)

Original comment by flier...@gmail.com on 14 Oct 2012 at 3:12