search

ironman5366 / W.I.L.L

A python written personal assistant
https://willbeddow.com
MIT License
377 stars 58 forks source link

Increasing greetings #33

Closed sathe-aditya closed 7 years ago

sathe-aditya commented 8 years ago

Hello! I'm new here, and was exploring around, when I observed that 'personality.txt' and 'personality.py' have greetings specific to a certain time of the day. I feel that maybe an addition of the day could be made, which can incorporate sentences such as, 'How is your Sunday going?', or 'TGIF! What are your plans for tonight?' This can increase the number of sentences W.I.L.L. can greet with!

Again, I am new here and have just observed this, please guide me in the correct direction if I am going wrong! :)

ironman5366 commented 8 years ago

Hi! Thanks for taking interest in W.I.L.L! Those are great suggestions for further greetings, and I'd be happy to implement them. However, I'll have to do it down the road. Right now, I'm working on an overhaul of the framework. But once it's finished, I'd be happy to put these into the new config. I'll keep this issue open so I can remember to do that when I merge the new framework through. Thanks!

sathe-aditya commented 8 years ago

Hey! It's great that my suggestions are of some value. :) If you don't mind, may I work on it and issue a pull request?

ironman5366 commented 8 years ago

Sure! However, when the dev branch gets pulled through in a month or so, it's gonna be overwritten. I'd suggest keeping your own version controlled greetings and then I'll integrate them when the frameworks settled.