search

ironman5366 / W.I.L.L

A python written personal assistant
https://willbeddow.com
MIT License
377 stars 58 forks source link

Keys/Tokens should be consolidated into a single config file #5

Closed brenttaylor closed 8 years ago

brenttaylor commented 8 years ago

You have a lot of different API's in use here, most of which need their own Token or API key. To get this running it's an exercise in running through most of the code base to find where to even enter them. The slack token for example is in main.py. Others are in text based config files scattered all over the place.

We should consolidate all of this into a single file.

ironman5366 commented 8 years ago

Also a good idea that I'm kicking myself for not thinking of. Do you want to take care of it or is this a feature request?

brenttaylor commented 8 years ago

I'll be happy to take care of this one too. This will make other contributions a lot easier since we won't have to keep removing all our API tokens from the code itself every time we commit changes.

EDIT: I'll work on this first and try and get it out tonight.

ironman5366 commented 8 years ago

Awesome thanks

brenttaylor commented 8 years ago

Just an update on this, due to circumstances beyond my control yesterday I didn't get to start on this. I'll be taking care of it today.

ironman5366 commented 8 years ago

Awesome, thanks

brenttaylor commented 8 years ago

16 should close this issue

ironman5366 commented 8 years ago

Thanks