ironmansoftware / issues

Public Issue tracker for Ironman Software products.
https://ironmansoftware.com
32 stars 2 forks source link

PSU Allows Duplicate Role Names #3383

Open JessePeden opened 3 weeks ago

JessePeden commented 3 weeks ago

Version

4.2.21

Severity

Low

Environment

msi

Steps to Reproduce

I just found out that PSU allow for duplicate roles to be created when dealing with the built-in roles (Administrator, User, Operator, Reader, Execute). The duplicate entries don't appear in the web UI but do appear in the roles.ps1 file. I have not been able to duplicate custom roles with unique names (such as Backup). I'm not sure if there is any functionality impact to the roles.ps1 file having duplicate entries, and if it would cause PSU to freak out, or allow identities/jobs/etc. to be mistakenly assigned a role with the same name a user intended (like thinking it was assigned to the built-in Administrator role but it was really assigned to the custom Administrator role, which may not have the same restrictions, etc.).

Expected behavior

PSU should not allow duplicate role names.

Actual behavior

PSU does allow duplicate role names.

Additional Environment data

No response

Screenshots/Animations

No response

adamdriscoll commented 3 weeks ago

This issue has been mentioned on Ironman Software Forums. There might be relevant details there:

https://forums.ironmansoftware.com/t/vault-psusecretstore-requires-a-password/10847/6