ironmansoftware / issues

Public Issue tracker for Ironman Software products.
https://ironmansoftware.com
31 stars 2 forks source link

Invalid User Name Set for External Git Client #3431

Closed adamdriscoll closed 3 days ago

adamdriscoll commented 1 week ago

Version

4.3.0

Severity

Low

Environment

msi

Steps to Reproduce

Description:

When using git external (ssh), author format needs to be in "Name ' format.

Regression introduced in 4.3.0 by issue #3322 - When using git external (ssh), author format needs to be in "Name ' format

Fixed an issue with commit author when using git and external git clients (#3322)

Environment:

After upgrading PSU 4.2.21 to PSU 4.3.0

Github Enterprise Server 3.12.4

PS C:\ProgramData\UniversalAutomation\Repository> git --version

git version 2.43.0.windows.1

Steps to reproduce:

On PSU 4.3.0 with git external enabled.

Start edit and save a script and try to commit.

Gives error “Fail to Commit”

Expected:

Git commit works correctly.

Extra diagnostics:

I was able to capture through our security/trace logs the commands that Powershell Universal tries to use when doing a git commit. This yielded that PSU executes the following commands.

"git" add Test/TestGit.ps1

"git" commit -m "Test git issue" --author "domain\xxxx"

When trying to run similar command using PSU Integrated terminal, the source reason is provided.

PS C:\ProgramData\UniversalAutomation\Repository> git commit -a -m "Test git issue" --author "domain\xxxx"

[ERROR] fatal: --author 'domain\xxxx' is not 'Name ' and matches no existing author

Feature enhancement request:

It would be nice to be more easily see the errors that PSU gets back in the logs from a git external commands without resorting to a trace/rerun commands.

Expected behavior

See above

Actual behavior

See above

Additional Environment data

No response

Screenshots/Animations

No response