search

ironmansoftware / powershell-universal

Issue tracker for PowerShell Universal
https://powershelluniversal.com
35 stars 2 forks source link

MSI - Check if service exists with service account #3587

Open mwatts-seg opened 1 month ago

mwatts-seg commented 1 month ago

Summary of the new feature / enhancement

MSI currently asks for service account name & password even when upgrading. image

Proposed technical implementation details (optional)

Not sure if I leave the field alone, would it not modify the service account attached. Installer should not prompt username/password if it detects there is an account already attached to the service.

adamdriscoll commented 1 month ago

I swear we added this because someone asked for it but now I have no idea what the reason was.

mwatts-seg commented 3 weeks ago

I swear we added this because someone asked for it but now I have no idea what the reason was.

@adamdriscoll I like having it. However, a think a couple of things could happen:

Idea 1:

Check if service account is already attached to the PowerShell Universal service, and if so, do not prompt for the information. 
Do not modify the service.

Idea 2: 

If I leave the field's blank, will it leave my service alone; leaving the account intact? 
If so, then I would say the wording needs to be adjusted to let the end user knows. 
If not, then changing how it is handled and the verbiage to the end user to reflect this.

Either would work. I wasn't sure if I left the boxes empty would it change it to SYSTEM. In an enterprise environment, our service accounts credentials are stored in a vault, and we have to retrieve them every time we need the password.