search

ironmansoftware / universal-automation

Universal Automation is the PowerShell-first automation platform.
https://ironmansoftware.com/universal-automation/
MIT License
24 stars 4 forks source link

Manual Time mislabeled as minutes #68

Closed Windos closed 4 years ago

Windos commented 4 years ago

Describe the Issue

On a script page in UD, the script's Manual Time is mislabeled as minutes when it should be seconds.

This appears to just be a label issue, it doesn't affect the accumulated time saved.

To Reproduce

Expected behavior

Seconds should be labeled seconds. (And I guess Hours should be labeled Hours if it scales up that high)

Screenshots

Scripts tab on home page showing correct label:

correct label

Same script, on script page, showing 20 Minutes rather than 20 Seconds:

incorrect label

Version Information

leeberg commented 4 years ago

Nice Catch - will marge a fix tonight :)

Windos commented 4 years ago

If it helps similar string handling is already on the script tab of the main page. I had a mix of seconds and minutes there

On Tue, 14 Jan 2020, 5:09 PM Lee Berg, notifications@github.com wrote:

Nice Catch - will marge a fix tonight :)

Will file an enhancement to do some string handling so 120 would read: 2 Minutes

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ironmansoftware/universal-automation/issues/68?email_source=notifications&email_token=ABVCGCSVIDREA6PT3KCXBOLQ5U3HFA5CNFSM4KGMPR2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI3GOJA#issuecomment-573990692, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVCGCTO7W6IUJPDSLFDC7DQ5U3HFANCNFSM4KGMPR2A .

leeberg commented 4 years ago

Yep! Just merged the fix!