ironmonk88 / monks-active-tiles

GNU General Public License v3.0
50 stars 31 forks source link

[BUG] v11 cannot update: documentTypes: is not a valid sub-types configuration: 'RegionBehavior' is not a valid Document type #792

Closed matjam closed 3 months ago

matjam commented 3 months ago

Describe the bug When installed in v11, updating the module fails when using the "Update All" feature in Foundry.

The specific error is

Error: Module validation errors:
  documentTypes: is not a valid sub-types configuration: 'RegionBehavior' is not a valid Document type
    at Setup.post (setup.js:5991:21)
    at async #updateCheck (setup.js:2927:24)
    at async update (setup.js:2729:23)

To Reproduce Steps to reproduce the behavior:

  1. Install Foundry v11
  2. Install an older version of monks active tiles
  3. Click the "Update All" button

Expected behavior I expect that either the module is updated, or it displays a message similar to the other monks modules. For example:

image

Screenshots image

Please complete as much of the following information as possible:

ironmonk88 commented 3 months ago

That's a Foundry issue. Not much I can do about that. You'll just keep seeing it until you update to v12.

LgocialHorus commented 3 months ago

I just saw in the changelog of Baileywiki Mass Edit that they somehow managed to fix that error: https://github.com/Aedif/multi-token-edit/blob/main/CHANGELOG.md

ironmonk88 commented 3 months ago

Pretty sure that's not related to this issue at all. Mass Edit doesn't add any additional behaviors to the Regions. Which is what Active Tiles does. And... there's not really a way around it. The updates are required in the manifest, but Foundry checks validity before checking version. So it's up to Foundry to fix their issue.

LgocialHorus commented 3 months ago

I see, sorry for the mix up.

Crowguard commented 3 months ago

https://github.com/foundryvtt/foundryvtt/issues/11188

Link to the Foundry ticket for it.

matjam commented 3 months ago

closing issue as the bug is in Foundry.