ironmonk88 / monks-combat-details

GNU General Public License v3.0
11 stars 7 forks source link

[BUG] Prevent Spell Changes option Prevent Change not working as expected #62

Closed gambit07 closed 7 months ago

gambit07 commented 9 months ago

Describe the bug There appears to be a few issues with this option at the moment. The first is that it does not seem to work with Warlock Pact slots at all. The second is that it does not work consistently for standard spell slots.

To Reproduce Warlock Pact Slots:

  1. With Prevent Change set in settings, login as a player character that is a warlock, level 8.
  2. Put the player character in combat and remove all spell slots as GM
  3. Modify players pact spell slots as the player character
  4. Player will be able to modify at will

Standard Spell Slots

  1. With Prevent Change set in settings, login as a player character that is a wizard, level 8
  2. Put the player character in combat and remove all spell slots as GM
  3. Take a long rest as the player character
  4. Any slot levels above 1st will be recovered. Player still will be unable to manually change any spell slot within the character sheet. This one is less an issue because players aren't long resting during combat, but figured it may give more context

Expected behavior The expectation is that no spell slot changes would occur for a player if a player is in combat with Prevent Change set in settings either through the character sheet or through long rest

Screenshots If applicable, add screenshots to help explain your problem.

Please complete as much of the following information as possible:

Additional context

ironmonk88 commented 7 months ago

Should be fixed in the latest release.